Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(export): add "in" suffix to netcdf export name when in validate mode #2090

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Dec 5, 2024

NetCDF exports when in validate mode don't contain timeseries data and are intended to generate files containing supported package input data. This update makes this more explicit by adding a input suffix identifier to the export.

For a model named "rch", a typical NetCDF export would be named "rch.nc". With this change, if running in validate mode, the export would be named "rch.in.nc".

The primary benefit of this change is that it avoids file name collisions if a user generates an input file in validate mode and then directly uses the file as a NetCDF input while also trying to generate a new timeseries export (with the same name).

Checklist of items for pull request

  • Replaced section above with description of pull request
  • Formatted new and modified Fortran source files with fprettify
  • Removed checklist items not relevant to this pull request

For additional information see instructions for contributing and instructions for developing.

@mjreno mjreno marked this pull request as draft December 5, 2024 18:23
@mjreno mjreno marked this pull request as ready for review December 10, 2024 12:42
@langevin-usgs langevin-usgs merged commit db33dd0 into MODFLOW-USGS:develop Dec 11, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants